Skip to content

Commit

Permalink
fix(OrbitControls): upstream fixes (pmndrs#365)
Browse files Browse the repository at this point in the history
  • Loading branch information
esquevin authored May 29, 2024
1 parent 430ffd7 commit 5bf7324
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions src/controls/OrbitControls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -408,18 +408,18 @@ class OrbitControls extends EventDispatcher {
scope.domElement.style.touchAction = 'none'
scope.domElement.addEventListener('contextmenu', onContextMenu)
scope.domElement.addEventListener('pointerdown', onPointerDown)
scope.domElement.addEventListener('pointercancel', onPointerCancel)
scope.domElement.addEventListener('pointercancel', onPointerUp)
scope.domElement.addEventListener('wheel', onMouseWheel)
}

this.dispose = (): void => {
// Enabling touch scroll
if(scope.domElement) {
if (scope.domElement) {
scope.domElement.style.touchAction = 'auto'
}
scope.domElement?.removeEventListener('contextmenu', onContextMenu)
scope.domElement?.removeEventListener('pointerdown', onPointerDown)
scope.domElement?.removeEventListener('pointercancel', onPointerCancel)
scope.domElement?.removeEventListener('pointercancel', onPointerUp)
scope.domElement?.removeEventListener('wheel', onMouseWheel)
scope.domElement?.ownerDocument.removeEventListener('pointermove', onPointerMove)
scope.domElement?.ownerDocument.removeEventListener('pointerup', onPointerUp)
Expand Down Expand Up @@ -858,10 +858,6 @@ class OrbitControls extends EventDispatcher {
state = STATE.NONE
}

function onPointerCancel(event: PointerEvent) {
removePointer(event)
}

function onMouseDown(event: MouseEvent) {
let mouseAction

Expand Down

0 comments on commit 5bf7324

Please sign in to comment.