Bugfix on Remove method.

rodoufu · Nov 13, 2018 · 9cdd257 · 9cdd257
1 parent 65f6113
commit 9cdd257
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/NeoDataStructure/MerklePatricia.cs b/NeoDataStructure/MerklePatricia.cs
@@ -193,9 +193,11 @@ private string Remove(string nodeHash, string path)
                         {
                             if (node[node.Length - 1] == null)
                             {
-                                var innerNode = _db[node[indexInnerNode]];
+                                var innerNodeHash = node[indexInnerNode];
+                                var innerNode = _db[innerNodeHash];
                                 if (innerNode.Length == LeafSize)
                                 {
+                                    _db.Remove(innerNodeHash);
                                     node = new[]
                                     {
                                         2 + innerNode[0].Length % 2 + "" + indexInnerNode + innerNode[0].Substring(1),

diff --git a/NeoDataStructureTest/MerklePatriciaTest.cs b/NeoDataStructureTest/MerklePatriciaTest.cs
@@ -99,6 +99,12 @@ void RemoverTestar(string x, string y)
             Assert.True(mp.Remove("a123"));
             // TODO Solve problem on the remove method, not removing from _db
             Assert.Equal(1, mp.Count());
+            Assert.False(mp.ContainsKey("a123"));
+            Assert.True(mp.ContainsKey("123"));
+            Assert.True(mp.ContainsKey("123"));
+
+            var mp2 = new MerklePatricia {["123"] = "abc"};
+            Assert.Equal(mp2, mp);
         }
 
         [Fact]