Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Metaprogramming attempt #100

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Misc] Extend metaprogramming to simple legacy objects
### Description

- Use the metaprogramming pattern to simple legacy objects using v3 endpoints

### Note
- Objects that have custom properties defined are left untouched
  • Loading branch information
invacuo committed Oct 18, 2021
commit 6c6c0887bc2d271a154d6da11ce515487e1cefac
3 changes: 0 additions & 3 deletions lib/spacex.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,11 @@
require_relative 'spacex/cores'
require_relative 'spacex/dragon_capsules'
require_relative 'spacex/endpoint'
require_relative 'spacex/history'
require_relative 'spacex/landing_pads'
require_relative 'spacex/launch_pads'
require_relative 'spacex/launches'
require_relative 'spacex/missions'
require_relative 'spacex/payloads'
require_relative 'spacex/roadster'
require_relative 'spacex/rockets'
require_relative 'spacex/ships'
require_relative 'spacex/version'

Expand Down
7 changes: 0 additions & 7 deletions lib/spacex/history.rb

This file was deleted.

12 changes: 12 additions & 0 deletions lib/spacex/models.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,16 @@ def self.info(id = nil, _query = {})
end)
end
end

KLASS_NAMES = %w[History Payloads Rockets].freeze

KLASS_NAMES.each do |klass_name|
SPACEX.const_set(klass_name, Class.new do
def self.info(object_id = nil, _query = {})
api_name = self.to_s.gsub('SPACEX::', '').downcase

SPACEX::BaseRequest.info("#{api_name}/#{object_id}")
end
end)
end
end
7 changes: 0 additions & 7 deletions lib/spacex/payloads.rb

This file was deleted.

7 changes: 0 additions & 7 deletions lib/spacex/rockets.rb

This file was deleted.