Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rodolfobandeira/spacex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 30c0f77
Choose a base ref
...
head repository: rodolfobandeira/spacex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 019bb8a
Choose a head ref
  • 6 commits
  • 16 files changed
  • 3 contributors

Commits on Oct 16, 2021

  1. Fix rubocop typo

    @rodolfobandeira
    rodolfobandeira committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    7d8c4f9 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix Dangerfile tests from forks (#97)

    @rodolfobandeira
    rodolfobandeira authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    cf277e5 View commit details
    Browse the repository at this point in the history

  3. Disable dangerbot

    @rodolfobandeira
    rodolfobandeira authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    bff25ed View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. final fix dangerbot (#99)

    @rodolfobandeira
    rodolfobandeira authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    461ef23 View commit details
    Browse the repository at this point in the history

  2. Implement V4::Rockets (#95) 

    ### Why?
Implement new [rockets endpoints](https://github.com/r-spacex/SpaceX-API/tree/master/docs/rockets/v4)

#### Description
- Added code to support two of the new endpoints
  - Get all rockets
  - Get a specific rocket by id
    @invacuo
    invacuo authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    1e609e1 View commit details
    Browse the repository at this point in the history

  3. [Misc] Metaprogramming attempt 

    ### Why?

Currently, we have to keep creating new classes for each endpoint that spacex api launches

These new classes are ***very** similar to each other

This is an attempt to avoid writing the main classes.

While this undeniably comes with the downsides of metaprogramming, I am wondering if we can alleviate some of that pain by continuing to write the individual specs and updating the readme file.
    @invacuo
    invacuo committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    019bb8a View commit details
    Browse the repository at this point in the history
Loading