Equations on corelib - #645
Open
mattam82 wants to merge 3 commits into
Open
Conversation
Issues with import order appeared. A new problem is that due to the use of a custom clos_trans definition, previous scripts which were automatically solving obligations with the "program_simpl" tactic now require to use `equations_simpl` instead. We put explicit "Local Obligation Tactic := CoreTactics.equations_simpl` directives to fix this (which is generally a good idea to document the automation being used).
|
Is it the plan to remove stdlib dependencies? Removing the dependency on the deprecated file PermutSetoid would put us much closer to being able to remove that file (rocq-prover/stdlib#151). |
|
Gentle ping. Is the intent to merge this PR, or should I make another overlay for the stdlib change? Thanks! |
Member
Author
|
Sorry I got sidetracked for a long time here, the goal is to merge this soonish, I'll get back to it next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.