[Review] Minor performance tweaks

[pt2121]

Hi guys,

First of all, thanks for this awesome work.
I'd like to propose to use Parcelable instead of Serializable in Emojicon class.
Hopefully, this might improve performance (as mention at http://www.developerphil.com/parcelable-vs-serializable/) and seems to align with Android best practices.

Also, I updated ViewHolder to be static based on Favor static member classes over nonstatic

Changes:

• Change from Serializable to Parcelable
• Favor static member classes over nonstatic
• Add build folder in .gitignore
• Bump build tool to 1.3.1

Thanks!

[rockerhieu]

Looks good, I will test it a bit and keep you posted.

[pt2121]

Thanks for merging!

[uwemaurer]

this throws an exception

Caused by: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to com.rockerhieu.emojicon.emoji.Emojicon[]

it can be fixed as described here: http://stackoverflow.com/questions/3647432/how-to-pass-an-array-of-address-objects-to-an-other-acitvity

[pt2121]

@uwemaurer Interesting. It worked fine when I tested it. Does it crash your app or something?

[uwemaurer]

yes, we see this exception in our exception reporting. (reported on Android 4.1.2 and 4.4.2 so far)

[pt2121]

@uwemaurer Maybe I am missing something but I can't reproduce this on emulators API 19 and 23. Anyway, I've sent a pull request (#79). Thanks

[uwemaurer]

I can reproduce it on my phone when I enable 'Don't keep activities' in the developer options. I can confirm that your pull request fixes it.

I got this stacktrace (maybe it has to do with the support library):

E/AndroidRuntime(26523): Caused by: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to com.rockerhieu.emojicon.emoji.Emojicon[]
E/AndroidRuntime(26523): at com.rockerhieu.emojicon.EmojiconGridFragment.onViewCreated(EmojiconGridFragment.java:70)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1035)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1197)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1179)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:1991)
E/AndroidRuntime(26523): at android.support.v4.app.Fragment.performActivityCreated(Fragment.java:1976)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1041)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1197)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1179)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:1991)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentController.dispatchActivityCreated(FragmentController.java:165)
E/AndroidRuntime(26523): at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:507)

[pt2121]

@uwemaurer Ok Thanks. It's good to learn something new every day!