Update CLI for apps to allow importing, exporting, and deleting by id in addition to name.#543
Open
phalestrivir wants to merge 1 commit intorockcarver:mainfrom
Open
Update CLI for apps to allow importing, exporting, and deleting by id in addition to name.#543phalestrivir wants to merge 1 commit intorockcarver:mainfrom
phalestrivir wants to merge 1 commit intorockcarver:mainfrom
Conversation
… by name or by id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the app export/import/delete commands to support doing those commands by id instead of by name. We've run into issues in the past where we would try to provide an id to do one of these commands (since the flag names suggest you need to provide the id), but would end up getting a 404 error since it would attempt to do so by name instead.
This PR also updates the tests, since I made a fix in this library PR that removes the legacy "application" from the export, since we are now using "managedApplication" instead. The "application" still exists on the export though whenever we are exporting OAuth client dependencies (since we use it for OAuth client applications), so I left it in the type definition in case there are OAuth client dependencies on the application still, but anytime there aren't dependencies the object will not be included (just as with the other dependencies).