Module Stability Workarounds #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Let's just wait a bit to see if they change the name of the library, otherwise we can go with this. Thanks for investigating! |
|
Never got a response. Let's merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables module stability for SwiftInfo releases, meaning you can use the same binary with any Swift >= 5 versions.
I did some hacky stuff to make it work, primarily updating
XcodeProj.swiftinterfaceto work around some bugs.Discussions in issue #68.
I'm going to leave this open here, feel free to close/update or propose other changes in case someone has a better solution.
I'm also closing #70 and using my fork because we are migrating to Xcode 12.5 in iFood.