Skip to content

Create Python venv instead of manual site-packages #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chhtz wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

Create Python venv instead of manual site-packages #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
3f833eb
Create Python venv instead of manual site-packages
chhtz Sep 24, 2025
9895c9d
fix install folders
planthaber Jan 22, 2026
f2949dd
copy python.rb code from autoproj feature/venv branch
planthaber Jan 22, 2026
691b303
actually create venv (once)
planthaber Jan 22, 2026
5c8409c
Enable venv by default on Ubuntu 24
chhtz Jan 26, 2026
e4bfcb9
Upgrade pip if no venv is created (necessary for Ubuntu 20.04)
chhtz Jan 29, 2026
80f1540
auto-install python-venv, when enabled
planthaber Jan 29, 2026
75a79fd
Merge branch 'feature/python_venv' of https://github.com/rock-core/pa…
planthaber Jan 29, 2026
6d824d5
move python init to overrides.rb (when osdeps are defined)
planthaber Jan 29, 2026
c7a0001
python: seperate config declare from init
planthaber Jan 29, 2026
4812f59
fix init_python
planthaber Jan 29, 2026
656c03a
fix: set python_bin in config setup
planthaber Jan 29, 2026
fbc2a0c
python split venv setup
planthaber Jan 29, 2026
85112c6
fix call
planthaber Jan 29, 2026
2f18b1b
python venv setup add require
planthaber Jan 29, 2026
f12e0d9
python fix function
planthaber Jan 29, 2026
4c34208
python: fix ws
planthaber Jan 29, 2026
c8f948d
fix osdep name
planthaber Jan 29, 2026
8a5a391
fix venv osdep name
planthaber Jan 29, 2026
a290725
fix osdep name
planthaber Jan 29, 2026
eacf422
move install back to test
planthaber Jan 29, 2026
e171e46
back to functional version
planthaber Jan 29, 2026
f1d84d7
install venv before using it
planthaber Jan 29, 2026
ea280cf
disable venv prompt
planthaber Jan 29, 2026
5e8c01f
Also move calling upgrade_pip to overrides.rb
chhtz Jan 29, 2026
26ea0c1
upgrade pip, if requested
planthaber Jan 30, 2026
efe2df1
fix pip upgrade
planthaber Jan 30, 2026
1aea050
run venv pip upgrade in subshell
planthaber Jan 30, 2026
dd5a1ca
fix upgrade call
planthaber Jan 30, 2026
fa735fe
fix call again
planthaber Jan 30, 2026
9054fa7
use vard for pip upgrade
planthaber Jan 30, 2026
553a6fd
print cmd
planthaber Jan 30, 2026
e229cf9
print cmd
planthaber Jan 30, 2026
bf5207e
remove return if ws.config.get("USE_PYTHON_VENV") guard for venv pip …
planthaber Jan 30, 2026
5cc8ae5
set PYTHON_VENV_FOLDER before usign it
planthaber Jan 30, 2026
8199dae
call venv pythob shim directly to upgrade pip
planthaber Jan 30, 2026
c71a538
use File.basename for python exe
planthaber Jan 30, 2026
f78be45
fix File.basename call
planthaber Jan 30, 2026
668b776
set PYTHON_VENV_EXECUTABLE and use it
planthaber Jan 30, 2026
fedc5d4
fix call
planthaber Jan 30, 2026
d68e389
fix get_python_from_venv
planthaber Jan 30, 2026
d9af405
use get_python_from_venv for pip upgrade
planthaber Jan 30, 2026
45990f2
fix get_python_from_venv call
planthaber Jan 30, 2026
8528d08
actually check PYTHON_VENV_UPGRADE_PIP config value
planthaber Jan 30, 2026
c04269b
python: switch config value and set venv version devault (if venv ena…
planthaber Jan 30, 2026
089b39b
fix: add missing ,
planthaber Jan 30, 2026
54de6aa
don't ask a second time for python executable when venv is enables
planthaber Jan 30, 2026
a65d70d
use getter for python_executable
planthaber Jan 30, 2026
f9489b6
fix: don't ask a second time for python exe
planthaber Jan 30, 2026
402e00f
don't run upgrade_pip on every call
planthaber Jan 30, 2026
c819bfd
improve pip upgrade
planthaber Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions overrides.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Rock.flavors.finalize

require File.join(__dir__, 'rock/python')
Rock.check_init_venv
Rock.check_upgrade_pip

Autoproj.env_add_path 'ROCK_BUNDLE_PATH', File.join(Autobuild.prefix, 'share', 'rock')
Autoproj.env_add_path 'ROCK_BUNDLE_PATH', File.join(Autoproj.root_dir, 'bundles')

Expand Down
3 changes: 3 additions & 0 deletions rock.osdeps-python3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ python-setuptools:
opensuse: python3-setuptools
gentoo: dev-python/setuptools

python-venv:
debian,ubuntu: python3-venv

cython:
debian, ubuntu: cython3
opensuse: python3-Cython
Expand Down
Loading