Fix node 24 compatibility (by using node-abi 4.11.0) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@tantaman could you also make a new release? :) |
|
building v1.0.8 now.
…On Thu, Jul 3, 2025 at 10:03 AM Max Stevens ***@***.***> wrote:
*maxstevens-nl* left a comment (rocicorp/zero-sqlite3#5)
<#5 (comment)>
@tantaman <https://github.com/tantaman> could you also make a new
release? :)
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHWK22UQHB2H45L2ZLJDZL3GUZ3HAVCNFSM6AAAAACAOMVUXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZSGQYDCNZVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@tantaman could you also publish to npm 🙈 |
|
womp womp. Yeah, it should go up today. The build got stuck and I didn't check it :( |
|
It is published finally 😬. Really need to figure out a smoother process. The build takes several hours in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces
prebuildto usenode-abiv4.11.0.In older versions of
node-abi, node 24 resolved to ABI v134, which was the pre-release version. This causes the prebuilds for node 24 to be published under ABI v134, meaning they're not resolved when building under ABI v137. This made the issue described here appear for me again.These changes are already made upstream: WiseLibs/better-sqlite3#1385