fix: better detail view for mobile #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please check on an actual phone too -- some of the interaction are weird on
mobile. Like when the sidebar flies out if you try to dismiss it, it opens
an issue too (it doesn't treat the sidebar as modal). You'll find most of
the issues just clicking around for a few mins on a real phone.
…On Wed, May 4, 2022 at 10:12 AM vercel[bot] ***@***.***> wrote:
*The latest updates on your projects*. Learn more about Vercel for Git ↗︎
<https://vercel.link/github-learn-more>
Name Status Preview Updated
*repliear* 🔄 Building (Inspect
<https://vercel.com/rocicorp/repliear/668gz8hydrKnVnaY8FRPmoQyFdkD>) May
4, 2022 at 8:12PM (UTC)
—
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATUBEBP5Y6ZDAA3YOFFHTVILK4HANCNFSM5VDCBTPQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
cesara
force-pushed
the
cesara/fix_detail_view_mobile
branch
from
09fafcd to
7e596af
Compare
cesara
force-pushed
the
cesara/fix_detail_view_mobile
branch
from
7e596af to
95eccfa
Compare
|
@aboodman ya im seeing a bunch of strange behavior on iOS. will fix in a separate PR. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.