Skip to content

Emit errors if there are errors in autoStartServer mode #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2017
Merged

Emit errors if there are errors in autoStartServer mode #45

merged 1 commit into from
Sep 6, 2017

Conversation

zbjornson
Copy link
Contributor

The code argument was ignored if autoStartServer was set to true, but it should be emitted as an "error" event.

@rochejul rochejul added this to the 1.1.1 milestone Sep 6, 2017
@rochejul rochejul self-assigned this Sep 6, 2017
@rochejul rochejul added the bug label Sep 6, 2017
@rochejul rochejul merged commit 77678df into rochejul:master Sep 6, 2017
@rochejul
Copy link
Owner

rochejul commented Sep 6, 2017

Many thanks for your contribution

I try to deploy ASAP

Regards

@zbjornson
Copy link
Contributor Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rochejul rochejul

Labels
bug
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zbjornson @rochejul