Fix invalid number literal suffix causing comptime eval crash #8910
+69
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing number literals like `0.F`, the tokenizer produces `Int,NoSpaceDotUpperIdent` which the parser interprets as a typed integer with type suffix `.F`. Previously, this invalid type suffix would cause a crash later in evaluation. This commit adds validation during canonicalization to check that the type suffix refers to a type that is actually in scope. If the type is not in scope (like `F` in `0.F`), the expression is replaced with e_runtime_error and a proper "UNDECLARED TYPE" diagnostic is emitted. Also includes a fix for the broken "check type - for mismatch" test after the numeric suffix deprecation (from PR #8884). Fixes #8893 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rtfeldman
force-pushed
the
fix-issue-8893
branch
from
45de4c1 to
dde737f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
0.F) to give proper "UNDECLARED TYPE" error instead of crashingTest plan
number_suffix_undeclared_type.mdthat verifies0.Fproduces "UNDECLARED TYPE" error123.U64still works correctly (U64 is in scope from Builtin imports)zig build minicipasses🤖 Generated with Claude Code