Add canonicalizer to coverage and improve to 81% #8875
Draft
+555
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expand `zig build coverage` to include canonicalizer tests - Add snapshot tests for canonicalizer coverage (major improvement) - Add 12 new Monomorphizer unit tests (32% -> 42%) - Add 5 new RocEmitter unit tests (57% -> 62%) - Make CoverageSummaryStep configurable for multiple modules - Set 80% minimum coverage threshold for canonicalizer Coverage improved from 47% (unit tests only) to 81% by including snapshot tests which exercise the full canonicalization pipeline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
kcov cannot capture coverage from cross-compiled binaries (musl target). Added a native ubuntu-22.04 build to the matrix specifically for running coverage tests, and modified the coverage condition to check that target_flag is empty. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- valgrind: only run on musl cross-compile (native glibc has valgrind issues) - static link check: only run on musl builds (native glibc is dynamically linked) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
kcov cannot capture coverage on GitHub Actions runners due to kernel security restrictions on ptrace. Coverage can still be run locally with: zig build coverage Also updated valgrind/static-link conditions to be more precise. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rtfeldman
force-pushed
the
can-coverage
branch
from
21bf204 to
d353fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
zig build coverageto include canonicalizer tests alongside parser testsCoverage Results
Overall: 81.45% (threshold set at 80%)
Test plan
zig build coveragepasses with both parser and canonicalizer coverage🤖 Generated with Claude Code