Load packages from main when the root is a module #6792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agu-z
commented
Jun 8, 2024
Collaborator
Author
There was a problem hiding this comment.
This was some dead code I found
Collaborator
|
Thank you very much 😀 |
lukewilliamboswell
approved these changes
Jun 11, 2024
Collaborator
lukewilliamboswell
left a comment
lukewilliamboswell
left a comment
There was a problem hiding this comment.
This works great. 👍
This was referenced Nov 3, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we load a
moduleas the root (e.groc check Module.roc), the compiler would hang when it encountered an import from a package. This happened because it would wait for the package shorthand to be resolved, but it never would because the main module (app/package) wouldn't be loaded.In this case, we will now recursively search for a
main.rocfile starting from the module's directory, and then parse its header and load the packages it specifies. We will not load the defs of the main module to avoid unnecessarily checking the whole tree.If the user wants to name the app something different, they can use a new
--mainCLI flag when runningroc check/roc dev. We don't have a way to specify this for the language server yet, but we should add it in the future.Finally, this adds proper reporting for unrecognized package shorthands. We will suggest from the available options, and indicate which main we are using to help troubleshoot when applicable.
Closes #6538
Closes #6185
Closes #6200
Closes #6388
Closes #6373
Closes #5961