-
-
Notifications
You must be signed in to change notification settings - Fork 366
Cleanup and Update Deps #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and Update Deps #1901
Conversation
|
So just for reference on the gains so far. Pretty minor, but: File sizeOld: 45.3MiB .text section size, the file size is 77.8MiB Compile time all tests (release no sccache)Old: 19m 08s Potenial duplicate package versionsOld: 51 deps with 107 versions |
|
|
||
| staging_belt.finish(); | ||
| cmd_queue.submit(Some(encoder.finish())); | ||
| surface_texture.present(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New requirement in wgpu 11
Anton-4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @bhansconnect! 🎉
|
An extra note, once the next release of winit is out, we should get another build improvement/speedup. Then we will stop building a lot of wayland and and ui stuff twice. Those are all packages that take a while to build. We should probably try to make sure |
I changed wasmer to use the llvm backend because it compiles the fastest and supports aarch64. If we later run into llvm versioning issues of some sort, we should switch this to cranelift. Also re-adds serde-json which is used on macos.
|
I think this should now be at a good pausing point to merge. There are still some other enhancements to be made, but they can be done in other PRs/have specific tracking issues. Here are the current times for An M1 macbook air Scary how fast M1 is at compiling. Theoreticaly M1 max can be close to 2x M1 speeds. |
Now all of the crates we directly depend on (except for palette and object) are updated to their newest versions. Including major version updates and some minor code changes. We still have a decent number of outdated and duplicate dependencies, but fixing them would require update the crates we depend on as opposed to updating roc.