Skip to content

Conversation

@bhansconnect
Copy link
Member

Now all of the crates we directly depend on (except for palette and object) are updated to their newest versions. Including major version updates and some minor code changes. We still have a decent number of outdated and duplicate dependencies, but fixing them would require update the crates we depend on as opposed to updating roc.

@bhansconnect bhansconnect requested a review from Anton-4 November 6, 2021 02:31
@bhansconnect
Copy link
Member Author

So just for reference on the gains so far. Pretty minor, but:

File size

Old: 45.3MiB .text section size, the file size is 77.8MiB
New: 42.3MiB .text section size, the file size is 73.5MiB

Compile time all tests (release no sccache)

Old: 19m 08s
New: 16m 32s

Potenial duplicate package versions

Old: 51 deps with 107 versions
New: 35 deps with 74 versions


staging_belt.finish();
cmd_queue.submit(Some(encoder.finish()));
surface_texture.present();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New requirement in wgpu 11

Anton-4
Anton-4 previously approved these changes Nov 6, 2021
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @bhansconnect! 🎉

@bhansconnect
Copy link
Member Author

An extra note, once the next release of winit is out, we should get another build improvement/speedup. Then we will stop building a lot of wayland and and ui stuff twice. Those are all packages that take a while to build. We should probably try to make sure winit and copypasta get updated in sync to avoid bloating build times.

I changed wasmer to use the llvm backend because it compiles the fastest and supports aarch64.
If we later run into llvm versioning issues of some sort, we should switch this to cranelift.
Also re-adds serde-json which is used on macos.
@bhansconnect
Copy link
Member Author

I think this should now be at a good pausing point to merge. There are still some other enhancements to be made, but they can be done in other PRs/have specific tracking issues.

Here are the current times for cargo build --release with no caches:
My 12 core i7 laptop
trunk: 10m 07s
deps: 8m 07s

An M1 macbook air
trunk: 2min 52s
deps: 2min 27s

Scary how fast M1 is at compiling. Theoreticaly M1 max can be close to 2x M1 speeds.

@folkertdev folkertdev merged commit 8798352 into trunk Nov 6, 2021
@folkertdev folkertdev deleted the deps branch November 6, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants