HTTP: Don't expect request bodies to be UTF-8 #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using UTF-8 strings for the request bodies is probably a remnant from times past. The bodies are raw bytes on the Roc-side and here we align with that. This enables requests like file uploads etc. which aren't UTF-8 strings.
Anton-4
approved these changes
Apr 4, 2025
Collaborator
Anton-4
left a comment
Anton-4
left a comment
There was a problem hiding this comment.
Looks good, thanks @niclas-ahden :)
niclas-ahden
added a commit
to niclas-ahden/basic-webserver
that referenced
this pull request
Apr 4, 2025
See: roc-lang/basic-cli#343 I needed to pull in the `roc_http` changes above and opted to update all crates as the dependencies are reasonably constrained in `Cargo.toml`.
Anton-4
pushed a commit
to roc-lang/basic-webserver
that referenced
this pull request
Apr 4, 2025
See: roc-lang/basic-cli#343 I needed to pull in the `roc_http` changes above and opted to update all crates as the dependencies are reasonably constrained in `Cargo.toml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using UTF-8 strings for the request bodies is probably a remnant from times past. The bodies are raw bytes on the Roc-side and here we align with that. This enables requests like file uploads etc. which aren't UTF-8 strings.