Refactor host into crate #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
reviewed
Apr 29, 2024
Collaborator
|
Looks great, nice to have a Roc build script! |
Collaborator
Author
|
Ok, I'll continue working on this and see if I can get the surgical linker part working too. |
lukewilliamboswell
force-pushed
the
refactor-host
branch
from
d8f66a8 to
7b3d122
Compare
lukewilliamboswell
changed the title
lukewilliamboswell
force-pushed
the
refactor-host
branch
from
7b3d122 to
a7cd259
Compare
lukewilliamboswell
force-pushed
the
refactor-host
branch
from
aafce3f to
874db71
Compare
add preprocessed host for surgical linking refactor to build artefacts for both legacy and surgical linking update build for preprocessing update build script add a glue script refactor host into crates try adding linker=legacy fix build.roc extensions add build platform binary step to CI stage the changes for surgical linker
lukewilliamboswell
force-pushed
the
refactor-host
branch
2 times, most recently
from
49769d4 to
6c7b159
Compare
smores56
reviewed
Jul 3, 2024
Anton-4
reviewed
Jul 15, 2024
Anton-4
previously requested changes
Jul 15, 2024
Collaborator
Anton-4
left a comment
Anton-4
left a comment
There was a problem hiding this comment.
There's just this question, all the rest looks great ❤️
Anton-4
reviewed
Jul 16, 2024
Not using --release does not work, so it should be the only option.
It requires setting env vars first to succeed.
Collaborator
|
🍾 we're ready to merge for my part, I'll just let @lukewilliamboswell review my changes |
Collaborator
Author
|
@Anton-4 -- looks good to me. Thank you for making those changes. |
bhansconnect
approved these changes
Jul 16, 2024
Collaborator
|
Massive effort 💪 Thank you very much @lukewilliamboswell ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the rust host files from the roc platform files, and adds a build script using a release of
basic-cli.The purpose of this change is to simplify the build process, and to have a clearer separation between these elements as this repository serves as an example of roc platforms.