Fix getProjectID misinterpreting args when flags present without config#5
Merged
robzolkos merged 1 commit intorobzolkos:masterfrom Mar 6, 2026
Conversation
When no .basecamp.yml config is found, getProjectID treated args[0] as project_id unconditionally. This caused misinterpretation when only a resource ID and flags were passed (e.g. `basecamp cards 5437262823 --column "TRIAGE"`), where the board_id would be consumed as project_id and the flag value became the board_id, resulting in 404 errors. Add a minPositionalArgs parameter to getProjectID so each command declares how many positional args it expects besides project_id. When no config is found, count non-flag positional args (skipping --flag value pairs). If there aren't enough for both project_id and the command's required args, return a clear error instead of misinterpreting. Fixes robzolkos#3
Owner
|
@rmmcgr thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no .basecamp.yml config is found, getProjectID treated args[0] as project_id unconditionally. This caused misinterpretation when only a resource ID and flags were passed (e.g.
basecamp cards 5437262823 --column "TRIAGE"), where the board_id would be consumed as project_id and the flag value became the board_id, resulting in 404 errors.Add a minPositionalArgs parameter to getProjectID so each command declares how many positional args it expects besides project_id. When no config is found, count non-flag positional args (skipping --flag value pairs). If there aren't enough for both project_id and the command's required args, return a clear error instead of misinterpreting.
Fixes #3
Created with the assistance of Claude Code.