-
Notifications
You must be signed in to change notification settings - Fork 286
add oci chart release for robusta #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdd GitHub Actions steps to authenticate to ghcr.io and package + push the Helm chart (helm/robusta) as an OCI artifact during the release workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Runner as Workflow Runner
participant GHCR as GitHub Container Registry (ghcr.io)
participant Helm as Helm (cli)
rect rgba(150,200,250,0.12)
Note over GH,Runner: Release workflow executes
end
GH->>Runner: checkout + setup
GH->>Runner: docker/login-action@v3 (registry: ghcr.io)
Runner->>GHCR: authenticate using GITHUB_TOKEN
GH->>Runner: run helm package helm/robusta
Runner->>Helm: create robusta-${env.RELEASE_VER}.tgz
GH->>Runner: run helm push robusta-${env.RELEASE_VER}.tgz oci://ghcr.io/.../charts
Runner->>GHCR: push OCI chart artifact
GHCR-->>Runner: accept/publish chart
GH->>GH: workflow completes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yaml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run_tests
🔇 Additional comments (2)
.github/workflows/release.yaml (2)
127-132: GitHub Container Registry login looks good.The GHCR login is correctly configured with the standard
docker/login-action@v3,ghcr.ioregistry, andGITHUB_TOKENfor authentication. The workflow permissions includepackages: write, which is appropriate.
134-137: All helm push configuration verified as correct.The three concerns have been confirmed:
The
helm pushsyntax for OCI registries in helm v3+ uses the formathelm push <archive>.tgz oci://<registry>/<repo>, which matches your code.Filename matching will work: Chart.yaml version is updated to
${{env.RELEASE_VER}}(lines 49, 51) beforehelm package helm/robustaexecutes, so the generated.tgzwill be namedrobusta-${{env.RELEASE_VER}}.tgzas expected.GHCR authentication is properly configured via the
docker/login-action@v3step (lines 127-132) with${{ secrets.GITHUB_TOKEN }}before the helm push command.The implementation is correct. Consider adding an explicit helm setup step if reproducibility across different runners is desired, but it's not required since helm is typically pre-installed on
ubuntu-latest.
|
@arikalon1 can this be looked at? |
arikalon1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @DrFaust92
|
@DrFaust92 Reviewed and merged - sorry for the slow turnaround |
|
thanks arikalon1! it needs a release to test. lmk if there are any issues and ill fix it |
|
@DrFaust92 I created a pre-release to test it, |
|
@arikalon1 the action run looks fine but no artifact to pull there should be something like this https://github.com/runatlantis/helm-charts/pkgs/container/charts%2Fatlantis |
|
@DrFaust92 I think it's here: https://github.com/robusta-dev/robusta/pkgs/container/charts%2Frobusta |
|
ok, it's defined as private - I'll check how to change that |
|
@DrFaust92 can you check now? |
|
yes, thanks @arikalon1 it looks good now. lmk if you can release a stable version for this |
|
we just released one yesterday @DrFaust92 |

closes #1801