Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAIN-1863] - avg utilization of mem/cpu #1502

Merged
merged 5 commits into from
Jul 24, 2024
Merged

[MAIN-1863] - avg utilization of mem/cpu #1502

merged 5 commits into from
Jul 24, 2024

Conversation

Avi-Robusta
Copy link
Contributor

No description provided.

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work
left some comments

@@ -526,7 +525,9 @@ def __update_cluster_status(self):
)

self.dal.publish_cluster_status(cluster_status)
self.dal.publish_cluster_nodes(cluster_stats.nodes, self.__pods_running_count)
avg_cpu = self.__prometheus_discovery_util.get_cluster_avg_cpu()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the db function work with None as cpu_utilization or memory_utilization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@arikalon1 arikalon1 merged commit 96472f2 into master Jul 24, 2024
8 checks passed
@arikalon1 arikalon1 deleted the avg_cpu_mem branch July 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants