New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing _get_sink_type method to zulip sink #1498

Merged

arikalon1 merged 1 commit into robusta-dev:master from oscgu:fix/zulip-sink-params

Jul 15, 2024

Contributor

oscgu commented Jul 15, 2024

Without the method the runner fails on startup:

sinks_config -> 0 -> zulip_sink
  Can't instantiate abstract class ZulipSinkParams with abstract method _get_sink_type (type=type_error)


          fix: add missing _get_sink_type method to zulip sink

429771c

arikalon1 approved these changes

View reviewed changes

Contributor

arikalon1 left a comment

nice work
thanks for the contribution

arikalon1 merged commit 80304c4 into robusta-dev:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet