Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holmes chart dependency #1471

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Holmes chart dependency #1471

merged 8 commits into from
Jun 24, 2024

Conversation

arikalon1
Copy link
Contributor

No description provided.

@arikalon1
holmes integration - WIP
86fbd01
@arikalon1
holmes integration - WIP
999e2cf
@arikalon1
holmes integration part 2
661be41
@arikalon1
Merge remote-tracking branch 'origin/holmes_chart_dependency' into ho…
d16fa9e 
…lmes_chart_dependency

# Conflicts:
#	helm/robusta/Chart.yaml
#	src/robusta/core/playbooks/internal/ai_integration.py
#	src/robusta/core/reporting/holmes.py
#	src/robusta/integrations/slack/sender.py
Avi-Robusta
Avi-Robusta approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Avi-Robusta Avi-Robusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly looks really good,
small comments but I dont think I need to look at the changes before you merge

@arikalon1 arikalon1 merged commit 6046af2 into master Jun 24, 2024
6 checks passed
@arikalon1 arikalon1 deleted the holmes_chart_dependency branch June 24, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-Robusta Avi-Robusta Avi-Robusta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arikalon1 @Avi-Robusta