Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN-1737 Warning events improved #1470

Merged
merged 12 commits into from
Jun 24, 2024
Merged

MAIN-1737 Warning events improved #1470

merged 12 commits into from
Jun 24, 2024

Conversation

Avi-Robusta
Copy link
Contributor

@Avi-Robusta Avi-Robusta commented Jun 24, 2024

We moved warning events to their own findings
you can see how they look in the timeline.
There is an option for a custom description for each warning event since it was spec-ed but we decided at this stage to not use it

Screen Shot 2024-06-24 at 13 15 30 Screen Shot 2024-06-24 at 13 15 09

Kept action event_report for backward compatibility

@Avi-Robusta Avi-Robusta marked this pull request as ready for review June 24, 2024 09:46
@Avi-Robusta Avi-Robusta changed the title Warning events improved MAIN-1737 Warning events improved Jun 24, 2024
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work
left one minor comment

playbooks/robusta_playbooks/event_enrichments.py Outdated Show resolved Hide resolved
@arikalon1 arikalon1 merged commit 7ca143d into master Jun 24, 2024
6 checks passed
@arikalon1 arikalon1 deleted the warning_events_improved branch June 24, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants