Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of records definition instead of records itself #1432

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

wrbbz
Copy link
Contributor

@wrbbz wrbbz commented May 21, 2024

Uses metrics definition instead of metrics record.

As was shown in #1168, those records could be absent on some Prometheus instances

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@aantn aantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@aantn aantn enabled auto-merge (squash) June 14, 2024 18:32
@aantn aantn merged commit 7001ddc into robusta-dev:master Jun 14, 2024
8 checks passed
@wrbbz wrbbz deleted the metrics-definition branch June 14, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants