Collect the data on the actual oomkilled container instead of the first one #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertSzefler
force-pushed
the
feature/main-1087/oom-kill-data-collection-improvements
branch
from
019aa50
to
a32c2fb
Compare
RobertSzefler
force-pushed
the
feature/main-1087/oom-kill-data-collection-improvements
branch
from
a32c2fb
to
b5b7646
Compare
arikalon1
reviewed
Nov 30, 2023
helm/robusta/values.yaml
Outdated
| @@ -160,7 +160,6 @@ builtinPlaybooks: | |||
| rate_limit: 3600 | |||
| actions: | |||
| - pod_oom_killer_enricher: {} | |||
There was a problem hiding this comment.
I think we should state explicitly attach_logs: true here
|
|
||
|
|
||
| class OomKillParams(ActionParams): | ||
| attach_logs: Optional[bool] = True |
There was a problem hiding this comment.
For backward compatibility, I think the default should be false
If someone is using this action, on a different playbook, he will suddenly start to get the logs.
He might have already configured it with logs_enricher, in which case he'll get the logs twice, or configured it without the logs_enricher and now will start to get logs
arikalon1
deleted the
feature/main-1087/oom-kill-data-collection-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.