[helm] fix about volume auth-config-secret definition if .rsa is nil #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavangudiwada
added
the
needs-review
arikalon1
approved these changes
Nov 18, 2023
pavangudiwada
pushed a commit
to pavangudiwada/robusta
that referenced
this pull request
Jun 25, 2024
…obusta-dev#1161) Co-authored-by: arik <alon.arik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 6ee8d1f introduced .Values.rsa.existingSecret.
It is not possible anymore to install the chart without defining rsa.
As .Values.rsa is nil by default, and it is a parent of existingSecret, the following change (runner.yaml) fails.