k8s vs Prometheus alert distinction in Slack sink code #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertSzefler
force-pushed
the
feature/prometheus-k8s-event-formatting
branch
from
5681c4b
to
94d83ee
Compare
arikalon1
approved these changes
Nov 15, 2023
| status_name: str = "👀 *K8s event detected*" | ||
| else: | ||
| # TODO how should we format findings with other sources? | ||
| status_name: str = "???" |
There was a problem hiding this comment.
I would just name this notification
RobertSzefler
force-pushed
the
feature/prometheus-k8s-event-formatting
branch
from
94d83ee
to
abed8a9
Compare
RobertSzefler
force-pushed
the
feature/prometheus-k8s-event-formatting
branch
from
abed8a9
to
ebd8c47
Compare
pavangudiwada
pushed a commit
to pavangudiwada/robusta
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the distinction between K8s events and Prometheus alerts in Slack messages. Also rephrases a message in the mail sink to be consistent with the Slack code.