Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct api version/type #1102

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: use correct api version/type #1102

merged 1 commit into from
Oct 5, 2023

Conversation

oscgu
Copy link
Contributor

@oscgu oscgu commented Sep 27, 2023

This makes it possible to deploy the servicemonitor when using an existing prometheus instance

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

@RoiGlinik RoiGlinik merged commit d94c226 into robusta-dev:master Oct 5, 2023
3 checks passed
@RoiGlinik
Copy link
Contributor

Thanks @OSCG great catch!

anakaiti pushed a commit to BrioHR/robusta that referenced this pull request Oct 31, 2023
pavangudiwada pushed a commit to pavangudiwada/robusta that referenced this pull request Nov 6, 2023
@oscgu oscgu deleted the fix/prometheus-servicemonitor-deployment branch March 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants