Jobs push changes #1023
Jobs push changes #1023
Conversation
# Conflicts: # playbooks/robusta_playbooks/event_enrichments.py
jobsInfo support hikaru Job with camelcase attribute names add new update single job function
| @@ -251,40 +255,14 @@ def external_video_enricher(event: ExecutionBaseEvent, params: VideoEnricherPara | |||
| @action | |||
| def resource_events_diff(event: KubernetesAnyChangeEvent): | |||
| new_resource = event.obj | |||
| if not isinstance(new_resource, (Deployment, DaemonSet, StatefulSet, Node, Job)): | |||
There was a problem hiding this comment.
pod and replicaset is missing here, so it will always return on pod/replicaset changes
| @@ -524,3 +534,58 @@ def __publish_new_namespaces(self, namespaces: List[NamespaceInfo]): | |||
|
|
|||
| def get_global_config(self) -> dict: | |||
| return self.registry.get_global_config() | |||
|
|
|||
| def __update_node(self, new_node: Node, operation: K8sOperationType): | |||
There was a problem hiding this comment.
will this be called every time a new pod is added or CPU/mem allocation changes?
There was a problem hiding this comment.
do you have a way of checking how often this is called
| if old_info is None: # Update may occur after delete. | ||
| return | ||
|
|
||
| new_info.job_data = old_info.job_data |
There was a problem hiding this comment.
can the new_info have different job data that isn't in old info, like pods? (other fields in data might not be mutable )
| return | ||
|
|
||
| new_info = self.__from_api_server_node(new_node, []) | ||
| new_info.memory_allocated = cache.memory_allocated |
There was a problem hiding this comment.
can the memory allocation/cpu/pods/count change on updates?
Like if a pod on a node is deleted wouldn't that change all the above?
| @@ -384,6 +384,8 @@ platformPlaybooks: | |||
| - on_statefulset_all_changes: {} | |||
| - on_replicaset_all_changes: {} | |||
| - on_pod_all_changes: {} | |||
| - on_node_all_changes: {} | |||
| - on_job_all_changes: {} | |||
There was a problem hiding this comment.
how noisy is this for jobs?
like on one job that runs a few pods how often is this called?
# Conflicts: # helm/robusta/values.yaml # playbooks/robusta_playbooks/event_enrichments.py # src/robusta/core/sinks/robusta/robusta_sink.py
remove unnecessary imports
node fix node_system_info naming issues add logic to prevent update on equal cache info some attributes fixes
* push jobs changes on job changes
* push jobs changes on job changes
No description provided.