Discovery preformance #1021
Merged
Discovery preformance #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replaced os.exit with sending the signal directly to the parent process -> sys.exit is called on correct thread. |
not critical since thread will be ended anyways by parent
arikalon1
approved these changes
Aug 12, 2023
pavangudiwada
pushed a commit
that referenced
this pull request
Aug 21, 2023
* added watchdog thread for discovery * fixing thread start * reducing stack traces * pod restart working * better comments * fixed watchdog restart pod * returning from thread not critical since thread will be ended anyways by parent * PR changes * updated exit * removing unneeded import
pavangudiwada
pushed a commit
to pavangudiwada/robusta
that referenced
this pull request
Nov 6, 2023
* added watchdog thread for discovery * fixing thread start * reducing stack traces * pod restart working * better comments * fixed watchdog restart pod * returning from thread not critical since thread will be ended anyways by parent * PR changes * updated exit * removing unneeded import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
needed to use os._exit(1) to kill robusta process
_thread.interrupt_main()still keeps other threads alive but calls handle_sigint in a parent thread(~10 threads killed, the rest are still alive image taken after interrupt_main called and see from logs robusta still runs)
sys.exit will only exit the current child thread so its not an option from watchdog