Skip to content

Add tests for disconnect using connect argument #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add tests for disconnect using connect argument #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7f2fc
Add tests for client disconnecting using the connect argument
May 9, 2025
f3e78e7
add mocks and assertions for connection and close events to the test
May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/lib/use-websocket.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ test('useWebsocket should work with just a url provided', () => {
})

test('readyState changes across readyState transitions', async () => {
const onCloseMock = jest.fn();
const onConnectionMock = jest.fn();
server.on("close", onCloseMock);
server.on("connection", onConnectionMock);

const {
result,
rerender,
Expand All @@ -44,9 +49,32 @@ test('readyState changes across readyState transitions', async () => {
expect(result.current.readyState).toEqual(ReadyState.CONNECTING);
await server.connected;
expect(result.current.readyState).toEqual(ReadyState.OPEN);
expect(onConnectionMock).toHaveBeenCalledTimes(1);

rerender({
initialValue: false
});

await server.closed;
expect(onCloseMock).toHaveBeenCalledTimes(1);

expect(result.current.readyState).toEqual(ReadyState.CLOSED);


rerender({ initialValue: true });

// for some reason, the connecting state is too fast here to show up, just wait for OPEN
await waitFor(() => {
expect(result.current.readyState).toEqual(ReadyState.OPEN);
});

await server.connected;
expect(onConnectionMock).toHaveBeenCalledTimes(2);

server.close();
await expect(result.current.readyState).toEqual(ReadyState.CLOSED);
await server.closed;
expect(onCloseMock).toHaveBeenCalledTimes(2);
expect(result.current.readyState).toEqual(ReadyState.CLOSED);
})

test('a function-promise based url works the same as a string-based url', async () => {
Expand Down