feat(model): add method parserOptions #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ricardo-lobo it looks nice! @JoaoPedroAS51 could you take a look ? |
|
@robsontenorio You can close this PR. It does not solve the Laravel compatibility issue as this PR doesn't work property with nested filters. 6098689 introduced a breaking change that needs to be properly address in a separated PR. If I have time I will create a new PR |
|
@robsontenorio @ricardo-lobo Hi! Thank you for the PR! I'll take a look soon, probably by the weekend. Then we can work on a fix for nested filters as well :) P.S Sorry for taking so long to address the issue, I've been really busy |
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to customise parser options.
Some frameworks, like Laravel, expect the array to be encoded with indices format instead of comma format.
This will allow to set a different option while respecting the current default.
See: #214 (comment)
Added tests and docs.