ivy: simplify an error message for a bad index

It repeated too much, and without the repetition is no less clear.
robpike · Jan 8, 2025 · b4f3aa6 · b4f3aa6
1 parent e1b2cb8
commit b4f3aa6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/testdata/exec_fail.ivy b/testdata/exec_fail.ivy
@@ -25,7 +25,7 @@ x
 (log 2)[1]
 	#
 
-# Expect: invalid index (2) (float) in 1 2 (float 2) in (1 2)[1 2 (float 2)]
+# Expect: invalid index (2) (type float) in (1 2)[1 2 (float 2)]
 1 2[1 2 (float 2)]
 	#
 

diff --git a/value/index.go b/value/index.go
@@ -43,7 +43,7 @@ func (ix *indexState) init(context Context, top, left Expr, index []Expr) {
 		x := index[i].Eval(context).Inner()
 		switch x := x.(type) {
 		default:
-			Errorf("invalid index %s (%s) in %s", index[i].ProgString(), whichType(x), top.ProgString())
+			Errorf("invalid index %s (type %s) in %s", index[i].ProgString(), whichType(x), top.ProgString())
 		case Int:
 			ix.indexes[i] = NewVector([]Value{x})
 		case *Vector:
@@ -59,7 +59,7 @@ func (ix *indexState) init(context Context, top, left Expr, index []Expr) {
 		}
 		for _, v := range ix.indexes[i].All() {
 			if _, ok := v.(Int); !ok {
-				Errorf("invalid index %s (%s) in %s in %s", v, whichType(v), index[i].ProgString(), top.ProgString())
+				Errorf("invalid index %s (type %s) in %s", v, whichType(v), top.ProgString())
 			}
 		}
 	}