Skip to content

Add Python 3.10 to CI #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add Python 3.10 to CI #132

wants to merge 4 commits into from

Conversation

auscompgeek
Copy link
Member

@auscompgeek auscompgeek commented Aug 8, 2021

Python 3.10.0rc1 is now available. We should run our tests early to see if we can catch any bugs before the final release.

@auscompgeek
Copy link
Member Author

Okay, we have a removed import:

  File "/opt/hostedtoolcache/Python/3.10.0-rc.1/x64/lib/python3.10/site-packages/schematics/types/base.py", line 19, in <module>
    from collections import Iterable, OrderedDict
ImportError: cannot import name 'Iterable' from 'collections' (/opt/hostedtoolcache/Python/3.10.0-rc.1/x64/lib/python3.10/collections/__init__.py)

This was fixed in schematics/schematics#576, but no release since then.

@auscompgeek
Copy link
Member Author

Hey, the tests pass on Python 3.10 with schematics 2.1.1. Good to know.

@auscompgeek auscompgeek changed the title Add Python 3.10-dev to CI Add Python 3.10 to CI Dec 31, 2021
@TheTripleV
Copy link
Member

Could you make all of the python versions strings?

@auscompgeek
Copy link
Member Author

dammit I hate YAML

@virtuald
Copy link
Member

virtuald commented Jan 7, 2022

Going to put this and #128 on a single branch to expedite testing, closing.

@virtuald virtuald closed this Jan 7, 2022
@virtuald virtuald deleted the ci-3.10 branch January 7, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants