Skip to content

Fix py.typed location #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fix py.typed location #118

merged 1 commit into from
Jan 21, 2021

Conversation

auscompgeek
Copy link
Member

No description provided.

@auscompgeek
Copy link
Member Author

So this works, but is there a better way of achieving this?

@virtuald
Copy link
Member

It feels like there should be a py.typed put next to each pyi file instead? Otherwise you're indicating that the entire package is typed, which isn't true.

@auscompgeek
Copy link
Member Author

Teams will be using our libraries with paths like wpilib.TimedRobot. If we only put the py.typed next to the pyi (which would be in wpilib._wpilib), that won't be covered.

@virtuald
Copy link
Member

the pyi isn't going to be used directly for that, it would be used for the underlying location?

@virtuald virtuald merged commit a76703c into robotpy:main Jan 21, 2021
@auscompgeek auscompgeek deleted the pep561 branch January 21, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants