Skip to content

recursive set all frame for non visible tabs items #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typesupply merged 2 commits into from
Apr 12, 2023
Merged

recursive set all frame for non visible tabs items #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dcd377
recursive set all frame for non visible tabs items
typemytype Apr 12, 2023
85a44f6
with nested tabs viewDidMoveToWindow is called multiple times
typemytype Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/vanilla/vanillaTabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
NSViewControllerTransitionSlideBackward,\
NSFont
from vanilla.vanillaBase import VanillaBaseObject, _breakCycles, _sizeStyleMap, VanillaCallbackWrapper, \
_reverseSizeStyleMap
_reverseSizeStyleMap, _recursiveSetFrame
from vanilla.nsSubclasses import getNSSubclass


Expand Down Expand Up @@ -195,13 +195,19 @@ def getNSTabView(self):
"""
return self._nsObject

_didPositionViews = False

def _positionViews(self):
if self._didPositionViews:
return
contentRect = self.getNSTabView().contentRect()
# only do after the first because
# adjusting the first gives it
# incorrect positioning
for item in self._tabItems[1:]:
item._setFrame(contentRect)
_recursiveSetFrame(item._nsObject)
self._didPositionViews = True

def _adjustPosSize(self, frame):
if self._nsObject.tabViewType() == NSNoTabsNoBorder:
Expand Down