Fix Tabs for Ventura. #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch to view controllers for some objects (NSTabViewController, NSSplitViewController, etc.) removes the responsibility for creating the view from vanilla to the controller. We need to be able to do our setup on the view all the same, so this makes it possible.
This is for #172, but I'm not sure if it solves the Ventura problem yet.
Member
Author
|
This PR is for #172. |
* viewDidMoveToWindow is also called when a view is removed from superview, so window() is None and no wrapper needs to call positionViews * VanillaTabsDelegate is gone, all delegate actions goes to the controller, which is already set. Every tabView has already a delegate * Removing some unnecessary imports and attributes * Adding doc strings
Member
|
looks good! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a thorough review. Ultimately the solution was to set the view frames relative to the tab view's contentRect. The contentRect is only available after the view moves to a window, so I wait until then to adjust the frames.