Skip to content

update testing #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

update testing #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54bf84
update testing
benkiel Sep 24, 2024
48b36e1
Missing 3.8, fixed
benkiel Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,21 @@ jobs:
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
strategy:
matrix:
python-version: ['3.9', '3.12']
python-version: ['3.8', 3.9', '3.10', '3.11', '3.12']
platform: [ubuntu-latest, macos-latest, windows-latest]
exclude: # Only test on the oldest and latest supported stable Python on macOS and Windows.
- platform: macos-latest
python-version: 3.9
- platform: windows-latest
python-version: 3.9
- platform: macos-latest
python-version: 3.12
python-version: 3.10
- platform: windows-latest
python-version: 3.12
python-version: 3.10
- platform: macos-latest
python-version: 3.11
- platform: windows-latest
python-version: 3.11
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ However, the import name for the package remains ``extractor``, without prefix.
:target: https://github.com/robotools/extractor/actions?query=workflow%3ATests
.. |PyPI Version| image:: https://img.shields.io/pypi/v/ufo-extractor.svg
:target: https://pypi.org/project/ufo-extractor/
.. |Python Versions| image:: https://img.shields.io/badge/python-3.7%2C%203.8%2C%203.9%2C%203.10-blue.svg
.. |Python Versions| image:: https://img.shields.io/badge/python-3.8%2C%203.9%2C%203.10%2C%203.11%2C%203.12-blue.svg
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Text Processing :: Fonts",
],
python_requires='>=3.7',
python_requires='>=3.8',
zip_safe=True,
)

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 3.0
envlist = py3{7,8,9,10}
Copy link
Contributor

@rimas-kudelis rimas-kudelis Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benkiel, does it make sense to specify this at all? Looking at the output of test runs, I see a lot of messages like "py3x: skipped because could not find python interpreter with spec(s): py3x" in each. This seems to duplicate what you specify in GitHub workflows config, so I wonder if there's any sense to keep this line (and maintain it in sync with what you have in run-tests.yaml) at all.

envlist = py3{8,9,10,11,12}
skip_missing_interpreters = true

[testenv]
Expand Down