Skip to content

Extract TrueType instructions to TTX assembly format #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Feb 17, 2021
Merged

Extract TrueType instructions to TTX assembly format #30

merged 39 commits into from
Feb 17, 2021

Conversation

@jenskutilek
Copy link
Contributor

@jenskutilek jenskutilek commented Jun 26, 2020

Just keeping track of my experiments here ... related discussion: unified-font-object/ufo-spec#93

@jenskutilek jenskutilek marked this pull request as draft June 26, 2020 12:45
@jenskutilek jenskutilek changed the title WIP: Extract TrueType instructions to htic format WIP: Extract TrueType instructions to TTX assembly format Oct 20, 2020
@jenskutilek
Copy link
Contributor Author

jenskutilek commented Oct 20, 2020 •
edited
Loading

I have changed the code so the extracted TrueType programs are in FontTools TTX assembly format.

The PR depends on fonttools/fonttools#2005, that's why the checks fail.

@jenskutilek
Copy link
Contributor Author

jenskutilek commented Oct 27, 2020

The checks fail because of Py3-only syntax. Is Python 2.7 support still a concern for extractor?

@typemytype
Copy link
Member

typemytype commented Oct 27, 2020

Nope, py 2.7 can be removed. Maybe in a different PR which you can pull into this PR

@jenskutilek jenskutilek marked this pull request as ready for review November 18, 2020 14:33
@jenskutilek jenskutilek changed the title WIP: Extract TrueType instructions to TTX assembly format Extract TrueType instructions to TTX assembly format Nov 18, 2020
@jenskutilek jenskutilek mentioned this pull request Nov 18, 2020
Merged
@jenskutilek
Copy link
Contributor Author

jenskutilek commented Nov 18, 2020

I think this is ready to be merged. Should we wait until the UFO spec (unified-font-object/ufo-spec#94) has been officially updated?

@benkiel
Copy link
Member

benkiel commented Feb 17, 2021

@jenskutilek Spec has been updated, merging.

@benkiel benkiel merged commit 55d4961 into robotools:master Feb 17, 2021
@jenskutilek
Copy link
Contributor Author

jenskutilek commented Feb 17, 2021

Thank you!

@moyogo
Copy link
Collaborator

moyogo commented Feb 17, 2021

@jenskutilek @benkiel
The component flags (round, useMyMetrics, overlap) are not part of the UFO public.truetype.instructions spec.
See unified-font-object/ufo-spec#162

@jenskutilek
Copy link
Contributor Author

jenskutilek commented Feb 17, 2021

I've disabled extraction of composite flags for now: #32

@moyogo
Copy link
Collaborator

moyogo commented Feb 17, 2021

Thanks @jenskutilek. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jenskutilek @typemytype @benkiel @moyogo