Fix find_package(iDynTree) when IDYNTREE_USES_ASSIMP is ON and BUILD_SHARED_LIBS is OFF #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHARED_LIBS is OFF If iDynTree builds static libraries, then the `iDynTreeConfig.cmake` should call `find_dependency(assimp REQUIRED)`
|
This is a fix similar to #642 . |
S-Dafarra
approved these changes
Apr 3, 2020
|
macOS build are failing due to robotology/whole-body-estimators#60 . |
|
I also added a workaround for robotology/whole-body-estimators#60 to avoid the macOS failures. The workaround assumes that the runner version gets updated together with the ImageVersion, but I am not sure if that is the case, see actions/runner-images#670 . |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If iDynTree builds static libraries, then the
iDynTreeConfig.cmakeshould callfind_dependency(assimp REQUIRED).Furthermore, add a workaround for robotology/whole-body-estimators#60 .