Remove all uses of IDYNTREE_TREE_INCLUDE_DIRS global variable #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IDYNTREE_TREE_INCLUDE_DIRS global variable dates back to CMake 2.8.7, when the "modern CMake" propagation of include usage requiremements via target_include_directories was not available, and one of the main iDynTree authors had quite a limited understanding of CMake in general. It used to contain all the include directories of iDynTree, but not it is not necessary. The only place in which it was still useful was: * Passing the include directories to SWIG. For this, now all the idyntree targets are inspected and the appropriate include directories are extracted from the target-specific INTERFACE_INCLUDE_DIRECTORIES properties. * Passing to tests the location of the testModels.h header that contains the location of test model files. This usage has been substitute with a new HEADER library idyntree-testmodels, that is linked in all tests that need to use the testModels.h header.
traversaro
force-pushed
the
cleanup/include-dirs
branch
from
20ad41e to
71d43a8
Compare
francesco-romano
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDYNTREE_TREE_INCLUDE_DIRS global variable dates back to CMake 2.8.7,
when the "modern CMake" propagation of include usage requiremements via
target_include_directories was not available, and the main author of iDynTree's CMake scripts
had quite a limited understanding of CMake in general.
It used to contain all the include directories of iDynTree, but not it is not
necessary. The only place in which it was still useful was:
are inspected and the appropriate include directories are extracted from the
target-specific INTERFACE_INCLUDE_DIRECTORIES properties.
of test model files. This usage has been substitute with a new HEADER library idyntree-testmodels,
that is linked in all tests that need to use the testModels.h header.