-
Notifications
You must be signed in to change notification settings - Fork 55
Roll out new version of the project template (2018/12/15) #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but they are not blocking the merge at all.
Thanks a lot @claudiofantacci this is amazing!
By the way, I noticed that we did not mention how to handle static variables in shared libraries in Windows. Unfortunately those are not handled by |
a04c51f
to
010a7e4
Compare
Well I guess we can address this as well in this PR. I was unaware of this "obscure issues" (cit.) under Windows. I'll try to understand the content of the linked material (thanks about that!) and then I'll add one more commit to the PR. In the meanwhile let's try to close all the ongoing discussions 👍 |
Let me add one more reply about this suggestion. |
55bf7bb
to
80805e8
Compare
Ping @drdanz 😁 |
80805e8
to
cb349e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Great! Let's merge it! 🎉 |
With this PR we now have a refreshed, shiny and awesome CMake template for exporting Cpp libraries!
In particular I tried to address all the entries of #33 by
dox
custom target (see Change PATH with DIRECTORY in doxygen CMakeLists #38).Let me know what you think and should you have any suggestion for improvements I'll try to address them asap! 👍
Closes #29, closes #30, closes #31, closes #32, closes #34, closes #35, closes #33, closes #38.