Fix hard coded values

[smakela]

• Updated valid_login.robot with values from resource.robot

[pekkaklarck]

I agree hard coded values aren't a good idea in general, but replacing them with variables makes the test pretty ugly. A much better solution would be changing the test to something like

*** Test Cases ***
Valid login
    Open browser to login page
    Input valid user name
    Input valid password
    Submit credentials
    Welcome page should be open

or possibly to

*** Test Cases ***
Valid login
    Open browser to login page
    Login as valid user with valid password
    Welcome page should be open

The problem with above solutions would be that they don't anymore demonstrate how to pass arguments to keywords. For demo purposes I prefer the current approach.

[smakela]

@pekkaklarck Yes. Those would be better solutions. Just learning the whole framework.
Thanks for the good examples!