-
Notifications
You must be signed in to change notification settings - Fork 54
Add tags to robot descriptions database #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07333df
to
17af4f6
Compare
Pull Request Test Coverage Report for Build 14196394399Details
💛 - Coveralls |
17af4f6
to
c6c9d95
Compare
@stephane-caron Great work! It also nice to tag manipulators, grippers, bipeds if you know what packages contain is. Btw, I am integrating Robot_descriptions to RobotCAD and currently made most of work. I want to make categories in UI based on your tags. I would be grateful if you could merge this quickly. |
cad0812
to
373f63a
Compare
Your project looks great 🤩 I've added a tag to each description based on the readme. Feel free to open a PR if you find some tags are missing. I will merge this PR now, and aim for a release of v1.16.0 of the project by the end of this week. |
Thank you for fast tags feature creating. |
This PR follows up the suggestion by @drfenixion in #130 by adding a
tags
field to the list of robot descriptions.Tags are implemented as sets of strings (rather than enumerations like we do for formats) to allow for various future usages. The current use case for tags is about morphology (e.g. "quadruped", "humanoid", ...), but in the future it may be pertinent to other use cases to filter over other features (e.g. "tendon_driven", "can_jump", ...)
This PR tags quadruped robot descriptions and adds an example showing how to load them all in Pinocchio: