Skip to content

fix: Follow-up fixes for #1172 #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2020
Merged

fix: Follow-up fixes for #1172 #1273

merged 3 commits into from
May 27, 2020

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented May 27, 2020

Fixes:

  • Do not skip passing values files when releases[].adhocDependencies/jsonPatches/jsonPatches exist
  • Fix the bug that resulted in any such release to ignore the chart version number specified in helmfile.yaml
  • Fix the issue that kustomization has not been properly chartified when a kustomization is specified on releases[].chart but there were no releases[].strategicMergePatches and jsonPatches specified

This is a follow-up PR for #1172

@mumoshu mumoshu changed the title fix: Do not skip passing values files when releases[].adhocDependencies/jsonPatches/jsonPatches exist fix: Follow-up fixes for #1172 May 27, 2020
A kustomization has not been properly chartified when a kustomization is specified on `releases[].chart` but there were no `releases[].strategicMergePatches` and `jsonPatches` specified.
This fixes that.
@mumoshu mumoshu merged commit 930f91a into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant