Open
Conversation
8 tasks
dkosowski87
approved these changes
Feb 26, 2026
Matvezy
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The use of np.log in timestep_embedding functions causes SAM3_3D inference to fail when torch_compile=True.
The reason is that when torch.compile traces this, dynamo sees -np.log(max_period) and tries to negate it through torch_function, which calls .neg() on the numpy float64 result — and numpy scalars don't have .neg(). Switching to math.log avoids the issue by returning a plain Python float.
Associated inference PR: roboflow/inference#2041
Type of Change
Testing
Test details:
Compilation with
torch_compile=Truesucceeds after ~20min withtorch_compile=True, model behaviour is not affectedChecklist
Additional Context