Skip to content

Only stretch image to resize if format is Stretch#352

Merged
SolomonLake merged 7 commits intomainfrom
fix/resize-format
Jan 17, 2025
Merged

Only stretch image to resize if format is Stretch#352
SolomonLake merged 7 commits intomainfrom
fix/resize-format

Conversation

@SolomonLake
Copy link
Contributor

Description

Only perform a optimizing "stretch" resize if that is the resize format. Without this fix it will produce incorrect predictions for resize formats such as "Fit within".

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested locally with the python package.

Any specific deployment considerations

none

Docs

  • Docs updated? What were the changes:

iurisilvio
iurisilvio previously approved these changes Jan 17, 2025
stellasphere
stellasphere previously approved these changes Jan 17, 2025
Copy link
Contributor

@stellasphere stellasphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only formatting

@stellasphere
Copy link
Contributor

discussed in tuple: moving var into proper scope

@SolomonLake SolomonLake merged commit e7654dd into main Jan 17, 2025
8 checks passed
@SolomonLake SolomonLake deleted the fix/resize-format branch January 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants