Add a path deviation analytics block to workflows #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PawelPeczek-Roboflow
previously requested changes
Sep 26, 2024
inference/core/workflows/core_steps/analytics/line_following/v1.py
Outdated
Show resolved
Hide resolved
inference/core/workflows/core_steps/analytics/line_following/v1.py
Outdated
Show resolved
Hide resolved
inference/core/workflows/core_steps/analytics/line_following/v1.py
Outdated
Show resolved
Hide resolved
| def euclidean_distance(point1, point2): | ||
| return np.sqrt(np.sum((point1 - point2) ** 2)) | ||
|
|
||
| def compute_distance(dist_matrix, i, j, path1, path2): |
There was a problem hiding this comment.
I am not Familiar with Frechet distance - as part of knowledge sharing, could u run a short session describing details
There was a problem hiding this comment.
I would be happy to do that - who would be most helpful to invite to the session?
There was a problem hiding this comment.
just fine if you record loom I would watch and ask follow up questions if I have one, I would be fine if you explain the concept of algorithm and some basic details regarding implementation
There was a problem hiding this comment.
That sounds good I will record a Loom to share tomorrow 👍
…to sb/add-line-follow
…to sb/add-line-follow
shantanubala
dismissed
PawelPeczek-Roboflow’s stale review
I just had a chance to address your comments - can you take another look? Thank you!
shantanubala
changed the title
shantanubala
requested review from
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
inference/core/workflows/core_steps/analytics/path_deviation/v1.py
Outdated
Show resolved
Hide resolved
grzegorz-roboflow
approved these changes
Sep 27, 2024
PawelPeczek-Roboflow
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes an analytics block that can be useful for analyzing the path or trajectory of detected objects in an image. It implements an algorithm for computing the Fréchet distance between the path of a detected object and an optimal path.
This can be useful for tasks like counting the number of cars taking a left turn, measuring the precision of a baseball pitch, or any other task where you want to measure the extent to which an object deviates from a desired path.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
TBD.
Any specific deployment considerations
No specific deployment considerations - it is a workflow block that builds on top of the existing structure.
Docs