Default to optimal confidence from model-eval#2206
Draft
leeclemnet wants to merge 1 commit intomainfrom
Draft
Conversation
a19cb78 to
5660d57
Compare
32fa48d to
473dd08
Compare
8288b2c to
33ea1b0
Compare
33ea1b0 to
262b5bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Model eval calculates F1-optimal confidence thresholds but they aren't currently used for model inference. This PR together with https://github.com/roboflow/roboflow/pull/11053 makes it so. This feature applies only to the inference_models pathway. The legacy inference pathways keep their existing default confidence.
The key changes are
Wire recommendedParameters from model_eval through to inference
New ConfidenceFilter and post_process_with_confidence_filter() wrapper (inference_models/models/base/)
Inference adapters route through the new wrapper (inference/core/models/inference_models_adapters.py)
API request schema (inference/core/entities/requests/inference.py)
OLD inference path compatibility (inference/core/models/{object_detection,instance_segmentation,classification}_base.py)
Plumbing
Dependencies:
Type of Change
Testing
Test details:
Checklist
Additional Context